[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Update lilygit.tcl (Issue 2092) (issue 5504092)
From: |
Carl . D . Sorensen |
Subject: |
Re: Update lilygit.tcl (Issue 2092) (issue 5504092) |
Date: |
Thu, 29 Dec 2011 19:15:36 +0000 |
On 2011/12/29 18:19:26, Graham Percival wrote:
On Thu, Dec 29, 2011 at 05:21:34PM +0000,
mailto:address@hidden wrote:
> The Push button is disabled by default; an experienced user can
enable
> it with a simple edit to the script.
By "disabled", do you mean "commented out" ? If new contributors
see a greyed-out button, they'll get confused and ask silly
questions. The UI should be designed to avoid silly questions[1].
On 2011/12/29 18:19:26, Graham Percival wrote:
On Thu, Dec 29, 2011 at 05:21:34PM +0000,
mailto:address@hidden wrote:
> The Push button is disabled by default; an experienced user can
enable
> it with a simple edit to the script.
By "disabled", do you mean "commented out" ? If new contributors
see a greyed-out button, they'll get confused and ask silly
questions. The UI should be designed to avoid silly questions[1].
By disabled, I mean it doesn't appear. It isn't commented out, but it's
not put into the user interface unless push_access is set to 1.
> I've also added support for an environment variable specifying the
> branch. This will allow lily-git users to work with more than one
patch
> simultaneously by doing
>
> LILYPOND_BRANCH=dev/fix-my-issue lilypond-git.tcl
hmm. I'll come back to this later.
If this is not used, the branch defaults to dev/local_working. The
environment variable is not needed and can easily be ignored by novices.
This is definitely not right; please branch off of master. We
have absolutely no guarantee that staging will compile the binary,
let alone the documentation.
I guess that is true. In my work, I always branch off staging, because
that is where I will have to push it.
So I can see that the working branch should be off master, and then when
pushing we should rebase off staging. i will fix that.
Thanks for the review.
Carl
http://codereview.appspot.com/5504092/
- Update lilygit.tcl (Issue 2092) (issue 5504092), Carl . D . Sorensen, 2011/12/29
- Re: Update lilygit.tcl (Issue 2092) (issue 5504092), graham, 2011/12/29
- Re: Update lilygit.tcl (Issue 2092) (issue 5504092), dak, 2011/12/29
- Re: Update lilygit.tcl (Issue 2092) (issue 5504092), pkx166h, 2011/12/29
- Re: Update lilygit.tcl (Issue 2092) (issue 5504092), Carl . D . Sorensen, 2011/12/29
- Re: Update lilygit.tcl (Issue 2092) (issue 5504092),
Carl . D . Sorensen <=
- Re: Update lilygit.tcl (Issue 2092) (issue 5504092), graham, 2011/12/30
- Re: Update lilygit.tcl (Issue 2092) (issue 5504092), dak, 2011/12/30
- Re: Update lilygit.tcl (Issue 2092) (issue 5504092), Carl . D . Sorensen, 2011/12/30
- Re: Update lilygit.tcl (Issue 2092) (issue 5504092), dak, 2011/12/31