[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Gets vertical skylines from grob stencils (issue 5626052)
From: |
joeneeman |
Subject: |
Re: Gets vertical skylines from grob stencils (issue 5626052) |
Date: |
Wed, 22 Feb 2012 09:34:43 +0000 |
http://codereview.appspot.com/5626052/diff/30003/lily/skyline.cc
File lily/skyline.cc (right):
http://codereview.appspot.com/5626052/diff/30003/lily/skyline.cc#newcode393
lily/skyline.cc:393: Skyline::Skyline (Building b, Real start, Axis
horizon_axis, Direction sky)
This isn't quite what I had in mind (for one thing, it means that the
caller has to be aware of buildings, calculating their slope, etc.)
what about
Skyline::Skyline (vector<pair<Point, Point> > const& segments, Axis,
Direction)?
it works similarly to Skyline::Skyline(vector<Box>...) except that the
resulting skyline shows the outline of the given set of line segments.
http://codereview.appspot.com/5626052/diff/30003/lily/skyline.cc#newcode647
lily/skyline.cc:647: out.merge (to_merge);
merge is linear, so this loop is quadratic.
http://codereview.appspot.com/5626052/
- Re: Gets vertical skylines from grob stencils (issue 5626052), (continued)
Re: Gets vertical skylines from grob stencils (issue 5626052), janek . lilypond, 2012/02/22
Re: Gets vertical skylines from grob stencils (issue 5626052),
joeneeman <=
- Re: Gets vertical skylines from grob stencils (issue 5626052), address@hidden, 2012/02/22
- Re: Gets vertical skylines from grob stencils (issue 5626052), Janek Warchoł, 2012/02/22
- Re: Gets vertical skylines from grob stencils (issue 5626052), address@hidden, 2012/02/22
- Re: Gets vertical skylines from grob stencils (issue 5626052), David Kastrup, 2012/02/22
- Re: Gets vertical skylines from grob stencils (issue 5626052), address@hidden, 2012/02/23
- Re: Gets vertical skylines from grob stencils (issue 5626052), Joe Neeman, 2012/02/23
- Re: Gets vertical skylines from grob stencils (issue 5626052), Janek Warchoł, 2012/02/23
- Re: Gets vertical skylines from grob stencils (issue 5626052), address@hidden, 2012/02/23
- Re: Gets vertical skylines from grob stencils (issue 5626052), Janek Warchoł, 2012/02/26
- Re: Gets vertical skylines from grob stencils (issue 5626052), address@hidden, 2012/02/26