|
| From: | dak |
| Subject: | Re: Eliminates the Hara_kiri_engraver. (issue 7061062) |
| Date: | Mon, 14 Jan 2013 18:25:24 +0000 |
https://codereview.appspot.com/7061062/diff/1/lily/axis-group-engraver.cc
File lily/axis-group-engraver.cc (right):
https://codereview.appspot.com/7061062/diff/1/lily/axis-group-engraver.cc#newcode122
lily/axis-group-engraver.cc:122: {
On 2013/01/14 18:20:44, Keith wrote:
On 2013/01/14 17:50:47, Keith wrote: > The property haraKiri [...] is now redundant with
keepAliveInterfaces.
>
Or with remove-empty, I suppose.
If you can access the value with
staffline_ && to_boolean(staffline_ -> get_property("remove-empty"))
at this point, that would seem to be simpler.
It would also mean that we can just leave keepAliveInterfaces alone when switching between harakiri behavior and otherwise. Having to override a complex variable back and forth for a basic switch in behavior is error-prone. https://codereview.appspot.com/7061062/
| [Prev in Thread] | Current Thread | [Next in Thread] |