|Subject:||Re: [frogs] trailing spaces|
|Date:||Tue, 26 May 2009 06:45:07 -0500|
|User-agent:||Thunderbird 220.127.116.11 (X11/20090409)|
Trevor Daniels wrote:
Graham Percival wrote Tuesday, May 26, 2009 12:02 PMOn Tue, May 26, 2009 at 11:41:17AM +0100, Trevor Daniels wrote:I've looked again more closely at your original patch. The reason it fails to apply is that line 45 in the existing version of /input/lsr/non-default-tuplet-numbers.ly has no trailing space (actually it's just a single blank line), but your patch attempts to match it with a line containing a single space. The same is true of line 13 in /input/new/non-default-tuplet-numbers.ly. There may be more; I think git am reports just the first one in each file.Sweet mao, this is getting beyond ridiculous. FROGS: for the love of free love and open source hippydom, somebody make a bloody python script that removes tailing spaces from lines. Then run it on our docs, including input/ stuff. Then add it to scripts/auxiliar, and make makelsr.py call it when it's finished, so we'll always have trailing-space-less input/lsr/ files. Expected time: 10 minutes (60 for a complete python newbie) for the initial python script, 10 minutes for running it, verifying the diffs look right, etc. 30 minutes for adding it to git, modifying makelsr.py, etc. Total 50 (or 100) minutes. Plus another 50-100 minutes for dealing with trailing whitespaces in the python script itself.That would be useful, but it's not the problem here. It's the patch that seems to have acquired trailing spaces, not the file in git. Trevor
Something I learned early on is that email attachments can get jacked up depending on how they're sent. I was sending stuff to Carl and he reported that they arrived with the wrong line endings even though they had the right endings on my end to start with. The solution was (and still is for me) to send any patches using the webmail interface for gmail (or juno or whatever) instead of using my local email client. This works for me and it might work for others. That was only for changed line endings, though.
For trailing spaces, I always strip them in a file I'm working on before committing and making the patch. It's easy to do this with the Geany editor (for Linux or Windows), as there's a menu command for it. Not sure about other editors.
I like the idea of writing the Python script but I can't commit to it right now because of another pressing task. If it hasn't been done in the next couple of weeks then I'll take a crack at it.
Jon -- Jonathan Kulp http://www.jonathankulp.com
|[Prev in Thread]||Current Thread||[Next in Thread]|