Re: [lmi] wx-2.9.0-RC2 testing [Was: wxmsw-2.9.0 (svn trunk) anomaly]

[Vadim Zeitlin]

On Wed, 06 May 2009 21:07:54 +0000 Greg Chicares <address@hidden> wrote:

GC> On 2009-03-14 17:42Z, Vadim Zeitlin wrote:
GC> > On Thu, 12 Mar 2009 12:54:47 +0000 Greg Chicares <address@hidden> wrote:
GC> [slightly reordered]
GC> > GC> > GC> ../src/common/docview.cpp:1327: warning: 'docNew' might be used 
uninitialized in this function
GC> [...]
GC> > GC> However, this warning still occurs with 
'wxWidgets-2009-03-12.tar.bz2'.
GC> 
GC> And with 'wxWidgets-2.9.0-RC2.tar.bz2' too. However:

 Unfortunately I still have no fresh ideas about how to deal with it...

GC> There's a new one with RC2:
GC> 
GC> cd ../src/stc && ./gen_iface.py
GC> [...]
GC> 
/opt/lmi/wx-scratch/wxWidgets-2.9.0-RC2/gcc-345-0dfab2b4c310b0ef57d1436ecbd1977a/bk-deps
 /MinGW_/bin/g++ -c -o monodll_PlatWX.o  -D__WXMSW__     -DWXBUILDING    
-I../src/png -I../src/zlib
GC> -I../src/expat/lib -DwxUSE_BASE=1 -DWXMAKINGDLL 
-I../src/stc/scintilla/include -I../src/stc/scintilla/src -D__WX__ -DSCI_LEXER 
-DLINK_LEXERS  -Wall -Wundef -Wunused-parameter -Wno-ctor-dtor-privacy
GC> -Woverloaded-virtual -D_LARGEFILE_SOURCE=unknown 
-I/opt/lmi/wx-scratch/wxWidgets-2.9.0-RC2/gcc-345-0dfab2b4c310b0ef57d1436ecbd1977a/lib/wx/include/i686-pc-mingw32-msw-unicode-release-2.9
 -I../include
GC> -O2 -fno-strict-aliasing  ../src/stc/PlatWX.cpp
GC> ../src/stc/PlatWX.cpp:143: warning: unused parameter 'extraFontFlag'

 This one is non trivial neither: extraFontFlag is in fact used in this
file but only as an argument for an empty inline function (which itself
does use WXUNUSED() around its parameter to avoid the same warning but this
is apparently not enough). IMO the compiler is being over eager here but
this (untested) patch might fix it:

--- include/wx/font.h   (revision 60512)
+++ include/wx/font.h   (working copy)
@@ -250,7 +250,7 @@
     wxString GetWeightString() const;

     // Unofficial API, don't use
-    virtual void SetNoAntiAliasing( bool WXUNUSED(no) = true ) {  }
+    virtual void SetNoAntiAliasing( bool no = true ) { wxUnusedVar(no); }
     virtual bool GetNoAntiAliasing() const { return false; }

     // the default encoding is used for creating all fonts with default

GC> > excluding of
GC> > GC> course a couple hundred lines like this:
GC> > GC>   stl_uninitialized.h:82: warning: '__cur' might be used 
uninitialized in this function
GC> > GC> that I don't believe we can do anything about.
GC> > 
GC> >  Wouldn't using -isystem for this directory help?
GC> 
GC> I have read the '-isystem' documentation. Let me ask which directory
GC> you would suggest using it for: the wx source directory? If you mean
GC> gcc's 'include/c++/3.4.5/bits/' directory, then...well, shouldn't
GC> gcc already consider that a "system" directory?

 I think it should but I believe it doesn't, for whatever reason (mix up
between DOS and Unix style paths is one thing coming to mind). Otherwise I
don't see why should it give warnings in files inside it. Of course, this
is, once again, untested so I could be totally wrong but I thought that
using it for the directory containing stl_uninitialized.h might help.

GC> BTW, here's a patch for building this release candidate with lmi's
GC> makefiles:

 Thank you for your testing!
VZ