lmi
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [lmi] [PATCH] wx_test_validate_output.cpp


From: Vadim Zeitlin
Subject: Re: [lmi] [PATCH] wx_test_validate_output.cpp
Date: Sun, 15 Feb 2015 01:06:05 +0100

On Sun, 25 Jan 2015 01:02:43 +0000 Greg Chicares <address@hidden> wrote:

GC> // ERASE THIS BLOCK COMMENT WHEN IMPLEMENTATION COMPLETE. The block
GC> // comment below changes the original specification, and does not
GC> // yet describe the present code. Desired changes:
GC> //  - Remove code corresponding to B and D above.
GC> //  - Then remove the entire /*...*/ comment block above (its
GC> //    remaining contents are incorporated in the first two
GC> //    paragraphs below).
GC> //  - Code the other tests specified below.

 Sorry for the delay, but here are, finally, patches implementing the
requested changes. I didn't have any particular problems with them, but
unfortunately while debugging one of the tests failures I discovered a bug
in wxUIActionSimulator::Text() which didn't simulate pressing "_" correctly
and synthesized "-" instead of it, which meant that the key phrase
"idiosyncrasy_spreadsheet" couldn't be entered into the dialog until I
fixed this in wxWidgets myself, so you will need to upgrade your wxWidgets
version once again, this time to f412007f617c0ffd8e8d336c5d4a18ac52ddd915
(see 
https://github.com/wxWidgets/wxWidgets/commit/f412007f617c0ffd8e8d336c5d4a18ac52ddd915
for the details if you're interested).


GC> // Consider renaming this file to 'wx_test_spreadsheet_output.cpp'
GC> // e.g., because its purpose is to test spreadsheet output only.

 I didn't do this yet because I'd like to finally finish my tool for
generating objects.make, Makefile.am and the MSVS project files I use from
the same master files list as using it will make file renaming more
painless. This tool is practically finished since quite a long time,
actually, I just need to document its use for lmi and post here about it,
so hopefully this will be done soon -- and then we could rename this test
as suggested above if you'd like to do it.


 As always, please let me know if you have any questions about or issues
with the attached patches and thanks in advance for integrating them,
VZ

Attachment: 0001-Removed-parts-of-the-spreadsheet-output-tests-not-ne.patch
Description: Text document

Attachment: 0002-Add-a-helper-for-finding-a-window-by-name-inside-Mvc.patch
Description: Text document

Attachment: 0003-Add-helper-tsv_ext-function-to-validate-output-test.patch
Description: Text document

Attachment: 0004-Implement-tests-verifying-the-trace-files-existence-.patch
Description: Text document

Attachment: 0005-Refactor-extract-wx_test_output_pdf-in-a-separate-he.patch
Description: Text document

Attachment: 0006-Factor-out-enter_comments_in_case_defaults_dialog-cl.patch
Description: Text document

Attachment: 0007-Implement-the-remaining-cases-of-the-census-outputs-.patch
Description: Text document

Attachment: 0008-Clean-up-unnamed.mec.xml-file-previously-left-over-f.patch
Description: Text document


reply via email to

[Prev in Thread] Current Thread [Next in Thread]