Re: [lmi] Latest wx version recommendation

[Greg Chicares]

On 2015-02-15 23:03, Vadim Zeitlin wrote:
> 
>  If you hadn't upgraded your version of wxWidgets yet, please consider
> upgrading it to a later 64797a78ea419b24cf82fe43faf9760c51de95f0 commit
> instead as it fixes a cosmetic, but noticeable, problem in wxDataViewCtrl
> appearance which affected lmi census view if it was scrolled horizontally
> (see http://trac.wxwidgets.org/ticket/16815 for more details about this
> bug).

It seemed sensible to use 2f239930eb3bc8a928a771d4659e46900907b11f,
which is the latest as of a few hours ago. Building it, I see:

../src/common/event.cpp:1611: warning: 'loop' might be used uninitialized in 
this function
../src/common/docview.cpp:1526: warning: 'docNew' might be used uninitialized 
in this function
../src/richtext/richtextbuffer.cpp:712: warning: passing `double' for 
converting 1 of `void wxColourBase::Set(unsigned char, unsigned char, unsigned 
char, unsigned char)'
../src/richtext/richtextbuffer.cpp:712: warning: passing `double' for 
converting 2 of `void wxColourBase::Set(unsigned char, unsigned char, unsigned 
char, unsigned char)'
../src/richtext/richtextbuffer.cpp:712: warning: passing `double' for 
converting 3 of `void wxColourBase::Set(unsigned char, unsigned char, unsigned 
char, unsigned char)'

We've seen (and dismissed) the first two before, but the warnings
about wxColourBase::Set()'s arguments are new. For ease of reference:

    708         {
    709             // Let's pretend our background is always white. Calculate 
a colour value
    710             // from this and the opacity.
    711             double p = 
attr.GetTextBoxAttr().GetShadow().GetOpacity().GetValue() / 100.0;
    712             shadowColour.Set((1.0 - p)*255 + p*shadowColour.Red(), (1.0 
- p)*255 + p*shadowColour.Green(), (1.0 - p)*255 + p*shadowColour.Blue()    712 
);
    713         }