lmi
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [lmi] [PATCH] wx_test_validate_output.cpp


From: Vadim Zeitlin
Subject: Re: [lmi] [PATCH] wx_test_validate_output.cpp
Date: Tue, 3 Mar 2015 23:51:44 +0100

On Mon, 02 Mar 2015 00:16:05 +0000 Greg Chicares <address@hidden> wrote:

GC> I have a question about the seventh patch:
GC>   http://lists.nongnu.org/archive/html/lmi/2015-02/txtiolB8rhO9q.txt
GC> +        // There could be an existing comment in this field, delete it 
first.
GC> +        // This does assume MSW-like key bindings.
GC> +        ui.Char(WXK_HOME);
GC> +        ui.Char(WXK_END, wxMOD_SHIFT);
GC> +        ui.Char(WXK_BACK);
GC> Will "MSW-like key bindings" cause this not to work with wxGTK?

 Yes. But this is not the only place where MSW key bindings are assumed, I
still have "make the tests pass under Linux" in my TODO list but it's not
nearly near the top...


GC> I've copied my results below. I expect
GC>   default_update: ERROR (Assertion failure: A message box "Unable to read 
file 'C:/etc/opt/lmi/default.ill'. [file 
/lmi/src/lmi/illustration_document.cpp, line 110] " was shown unexpectedly, 
expected defaults dialog. [file /lmi/src/lmi/wx_test_default_update.cpp, line 
96, in run()].)
GC> until that test is made conditional on '--distribution',

[As an aside, I'll post the long due patch doing this soon]

GC> but is this error:
GC>   validate_output_census: ERROR (Assertion 'output_values.exists()' failed 
(file "C:/opt/lmi/bin/values.tsv" after print case to PDF). [file 
/lmi/src/lmi/wx_test_validate_output.cpp, line 360] )
GC> expected?

 No :-( I am not sure why don't I see it here, my only (not grounded in any
fact) hypothesis is that you might have some different values in your
configurable_settings.xml, e.g. for the "print_directory" or
"spreadsheet_file_extension" keys? In my case they have what I believe to
be the default values: "C:/opt/lmi/bin" and ".tsv" respectively.

 If you do have the same values there, then I'm afraid that I need help
from you in diagnosing this issue. I'd like to ask you to check if the
expected output file is created under a different name or maybe in a
different directory, either by using "find /cygdrive/c -mmin -5" (5 is
probably too big, the test shouldn't take that long but just to be sure) or
by monitoring the files created by the test in real time with Process
Monitor (https://technet.microsoft.com/en-us/library/bb896645.aspx).

 Also, and perhaps even before doing this, could you please check if
performing the same steps as the test does manually creates the expected
file?

 Thanks in advance for your help,
VZ

reply via email to

[Prev in Thread] Current Thread [Next in Thread]