Re: [lmi] [PATCH] Error reporting

[Greg Chicares]

On 2015-03-09 18:52, Vadim Zeitlin wrote:
> On Fri, 05 Dec 2014 20:47:32 +0000 Greg Chicares <address@hidden> wrote:
> 
> GC> We accidentally made a change that prevented wx errors from being
> GC> displayed. I'd like to add an automated test that would flag that
> GC> problem in case we accidentally make a similar mistake in the future.
> 
>  I definitely agree that it's important to have a test for this, but
> this did require some more extensive changes, let me explain why:
[...big snip...]

Committed
  20150326T2250Z, revision 6146;
  20150326T2257Z, revision 6147;
  20150326T2308Z, revision 6148; and
  20150326T2327Z, revision 6149.

I forced the fourth patch manually (it seemed to conflict with an
earlier one). It's so simple that I "couldn't possibly get it wrong",
which means mistakes are likely here: please check my work carefully.
[Always a good idea anyway, as I sometimes make minor changes without
mentioning them, such as where git diff obscures my email address.]

> So while this fourth patch doesn't do
> any harm with the current wxWidgets version, neither does it really help
> and for everything to work correctly you also need to get this fix:
> 
> https://github.com/wxWidgets/wxWidgets/commit/bcacb4467e2735f5fb2ac2bf30f7e06dd7ab7d64
> 
> I don't think it's necessary to upgrade your version of wxWidgets
> immediately, as I said, the patch above does no harm and everything does
> work correctly with the current tests. But the wx commit above will help
> with the errors clarity if we ever have unexpected wxLog messages when you
> upgrade to it.

For now, we'll bear that in mind, without upgrading wx at this time.