Re: [Ltib] [PATCH] mtd-utils-20060302.spec: Install userspace header files.

[Robert P. J. Day]

On Tue, 30 Dec 2008, Stuart Hughes wrote:

> Hi Robert,
>
> That looks like a good change.  However note that this version mtd-utils
> is only really intended for the host support utilities so that they
> don't need lzo.  The common package for target systems is mtd-utils.spec
> which is from 20080618.
>
> Regards, Stuart

  yes, i see your point.  i'm slowly getting the hang of this.  have i
already submitted a packaging of mtd-utils-1.2.0?  i'm pretty sure i
have one around here somewhere, and it's slightly newer than 20080618
and represents an official versioned release, which i typically prefer
to date-based snapshots.

rday

>
> On Mon, 2008-12-29 at 04:55 -0500, Robert P. J. Day wrote:
> > Fix what looks like an obvious copy-and-paste typo, and carry over
> > from the 20050523 the instructions to install the userspace MTD header
> > files.
> >
> > Signed-off-by:  Robert P. J. Day <address@hidden>
> >
> > ---
> >
> >    When I upgraded from mtd-utils 20050532 to 20060302, one of our userspace
> > apps failed to compile as it was attempting to
> >
> >    #include <mtd/mtd-user.h>
> >
> > This seemed like an obvious oversight in not installing the userspace
> > headers as was done in 20050523.  If I'm misreading this, let me know.
> > This patch does indeed fix the compilation.
> >
> > Index: mtd-utils-20060302.spec
> > ===================================================================
> > --- mtd-utils-20060302.spec     (revision 596)
> > +++ mtd-utils-20060302.spec     (working copy)
> > @@ -19,7 +19,7 @@
> >   %Description
> >   %{summary}
> >
> > -Extracted from the cvs snapshot: mtd-snapshot-20050523.tar.bz2
> > +Extracted from the cvs snapshot: mtd-snapshot-20060302.tar.bz2
> >   at http://www.linux-mtd.infradead.org/
> >
> >
> > @@ -37,6 +37,8 @@
> >   rm -rf $RPM_BUILD_ROOT
> >   mkdir -p $RPM_BUILD_ROOT/%{pfx}/%{_prefix}/bin
> >   make -C util DESTDIR=$RPM_BUILD_ROOT/%{pfx} SBINDIR=%{_prefix}/bin
> > MANDIR=%{_mandir} install
> > +mkdir -p $RPM_BUILD_ROOT/%{pfx}/%{_prefix}/include/mtd
> > +install -m0644 include/mtd/*.h 
> > $RPM_BUILD_ROOT/%{pfx}/%{_prefix}/include/mtd
> >
> >   %Clean
> >   rm -rf $RPM_BUILD_ROOT
> >
> >
> >
> >
> > _______________________________________________
> > LTIB home page: http://bitshrine.org
> >
> > Ltib mailing list
> > address@hidden
> > http://lists.nongnu.org/mailman/listinfo/ltib
>

========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry:
    Have classroom, will lecture.

http://crashcourse.ca                          Waterloo, Ontario, CANADA
========================================================================