Re: [Ltib] [PATCH] mtd-utils-20060302.spec: Install userspace header files.

[Stuart Hughes]

Hi Robert,

I've applied your patch, and also updated the common package.  BTW
people could debate whether we should actually install the headers from
the kernel's copy, but overall I favour using the ones from the
mtd-utils package.

So far as mtd-utils goes, I don't think it's worth updating to 1.2.0 if
the changes are small. 

As an aside, even when if/when it's upgraded (maybe to 1.2.x) I'd still
need to name the version as yyyymmdd.  The reason is a bit convoluted,
but here goes:  Normally packages built and installed by LTIB for the
target are unconditionally installed when built.  This is okay.
However, for the few host support packages this is not desirable as we
don't want someone installing an older BSP to downgrade the package
versions of the host support packages.  To make sure this happens, for
host support packages (only) a version check is made and only newer
versions are allowed to be installed.  At some point mtd-utils had to
use a snapshotted version string, so now we must always do this.  If we
do not, the newer package would not be installed.  Take for example
changing the version from 20080618 to 1.2.0, the way the version
comparison happens (and that's another story to ask the rpm people)
1.2.0 < 20080618 and so the desired install would not happen.

Regards, Stuart

On Tue, 2008-12-30 at 06:21 -0500, Robert P. J. Day wrote:
> On Tue, 30 Dec 2008, Stuart Hughes wrote:
> 
> > Hi Robert,
> >
> > That looks like a good change.  However note that this version mtd-utils
> > is only really intended for the host support utilities so that they
> > don't need lzo.  The common package for target systems is mtd-utils.spec
> > which is from 20080618.
> >
> > Regards, Stuart
> 
>   yes, i see your point.  i'm slowly getting the hang of this.  have i
> already submitted a packaging of mtd-utils-1.2.0?  i'm pretty sure i
> have one around here somewhere, and it's slightly newer than 20080618
> and represents an official versioned release, which i typically prefer
> to date-based snapshots.
> 
> rday
> 
> >
> > On Mon, 2008-12-29 at 04:55 -0500, Robert P. J. Day wrote:
> > > Fix what looks like an obvious copy-and-paste typo, and carry over
> > > from the 20050523 the instructions to install the userspace MTD header
> > > files.
> > >
> > > Signed-off-by:  Robert P. J. Day <address@hidden>
> > >
> > > ---
> > >
> > >    When I upgraded from mtd-utils 20050532 to 20060302, one of our 
> > > userspace
> > > apps failed to compile as it was attempting to
> > >
> > >    #include <mtd/mtd-user.h>
> > >
> > > This seemed like an obvious oversight in not installing the userspace
> > > headers as was done in 20050523.  If I'm misreading this, let me know.
> > > This patch does indeed fix the compilation.
> > >
> > > Index: mtd-utils-20060302.spec
> > > ===================================================================
> > > --- mtd-utils-20060302.spec     (revision 596)
> > > +++ mtd-utils-20060302.spec     (working copy)
> > > @@ -19,7 +19,7 @@
> > >   %Description
> > >   %{summary}
> > >
> > > -Extracted from the cvs snapshot: mtd-snapshot-20050523.tar.bz2
> > > +Extracted from the cvs snapshot: mtd-snapshot-20060302.tar.bz2
> > >   at http://www.linux-mtd.infradead.org/
> > >
> > >
> > > @@ -37,6 +37,8 @@
> > >   rm -rf $RPM_BUILD_ROOT
> > >   mkdir -p $RPM_BUILD_ROOT/%{pfx}/%{_prefix}/bin
> > >   make -C util DESTDIR=$RPM_BUILD_ROOT/%{pfx} SBINDIR=%{_prefix}/bin
> > > MANDIR=%{_mandir} install
> > > +mkdir -p $RPM_BUILD_ROOT/%{pfx}/%{_prefix}/include/mtd
> > > +install -m0644 include/mtd/*.h 
> > > $RPM_BUILD_ROOT/%{pfx}/%{_prefix}/include/mtd
> > >
> > >   %Clean
> > >   rm -rf $RPM_BUILD_ROOT
> > >
> > >
> > >
> > >
> > > _______________________________________________
> > > LTIB home page: http://bitshrine.org
> > >
> > > Ltib mailing list
> > > address@hidden
> > > http://lists.nongnu.org/mailman/listinfo/ltib
> >
> 
> ========================================================================
> Robert P. J. Day
> Linux Consulting, Training and Annoying Kernel Pedantry:
>     Have classroom, will lecture.
> 
> http://crashcourse.ca                          Waterloo, Ontario, CANADA
> ========================================================================