Re: [Maposmatic-dev] [PATCH ocitysmap] Improve the map_areas table name parametrization

[Maxime Petazzoni]

Hi,

* David MENTRE <address@hidden> [2010-01-25 11:22:23]:

> > A table name prefix can now be provided to the OCitySMap initalization
> > function instead of through the configuration file. The map_areas table
> > name is then constructed from this prefix with '<prefix>map_areas'.
> > Example prefixes are: 'RENDERERNAME_PID_', 'myjob_', 'another_'.
> 
> Ok for me. We need to take care of conf files when deploying this on
> dev or prod.

Yes, indeed. And the same goes for the new daemon (other patch series)
which has a dramatically different invocation method.

> > The temporary table is also now automatically cleaned up after
> > processing (failing or not).
> 
> I haven't seen in your patch where you guarantee this.

In ocitysmap:ocitysmap/street_index.py#OCitySMap:__init__ :

+        finally:
+            LOG.debug('Restoring database state...')
+            db.rollback()
+            self._del_map_areas(db)

- Maxime
-- 
Maxime Petazzoni <http://www.bulix.org>
 ``One by one, the penguins took away my sanity.''
Linux kernel and software developer at MontaVista Software

signature.asc
Description: Digital signature