monotone-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Monotone-devel] Status on multiple --message commit patch?


From: Thomas Moschny
Subject: Re: [Monotone-devel] Status on multiple --message commit patch?
Date: Wed, 11 Oct 2006 14:51:28 +0200
User-agent: KMail/1.9.4

On Wednesday 11 October 2006 10:41 Nathaniel Smith wrote:
> The offending change in all the cases I looked at seemed to be that with
> the patch, "-m foo" now causes the commit message to be "foo\n",
> rather than straight "foo".  Not too unreasonable a change...

Do we really want to unconditionally append a newline to *all* commit messages 
from now on? Personally, I don't think this is a good idea.

Btw, the method used here is called `join_lines'. To me, this name doesn't 
indicate that it appends a newline after the last line of it's input. 
However, join_lines is used in content_merger::try_to_merge_files(), so I 
didn't dare to change it :)

Thomas




reply via email to

[Prev in Thread] Current Thread [Next in Thread]