Re: [Monotone-devel] Status on multiple --message commit patch?

[Evan Deaubl]

Well, this patch isn't going too swimmingly, now is it? :-/  I promise 
the next one will go more smoothly (not that hard to do :-) ).

I could have sworn when I looked at the commit messages that were 
produced using the old -m, they had a newline attached, but I guess I 
was mistaken.  It would not be hard to either strip that last newline 
after the join_lines() to restore previous functionality, or change the 
existing or add a new join implementation that doesn't append the join 
separator to the end of the result (in agreement that join_lines() is a 
little misleading).  If the newline has got to go, I'm willing to clean 
up the mess either way. :-)

Evan Deaubl
address@hidden

Thomas Moschny wrote:
> On Wednesday 11 October 2006 10:41 Nathaniel Smith wrote:
> > The offending change in all the cases I looked at seemed to be that with
> > the patch, "-m foo" now causes the commit message to be "foo\n",
> > rather than straight "foo".  Not too unreasonable a change...
>
> Do we really want to unconditionally append a newline to *all* commit messages 
> from now on? Personally, I don't think this is a good idea.
>
> Btw, the method used here is called `join_lines'. To me, this name doesn't 
> indicate that it appends a newline after the last line of it's input. 
> However, join_lines is used in content_merger::try_to_merge_files(), so I 
> didn't dare to change it :)
>
> Thomas
>
>
> _______________________________________________
> Monotone-devel mailing list
> address@hidden
> http://lists.nongnu.org/mailman/listinfo/monotone-devel