[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Monotone-devel] BUG: "mtn diff" vs. "diff" with respect to not exis

From: Ralf S. Engelschall
Subject: Re: [Monotone-devel] BUG: "mtn diff" vs. "diff" with respect to not existing trailing newline on last line
Date: Fri, 7 Mar 2008 13:33:16 +0100
User-agent: Mutt/1.5.17 OpenPKG/CURRENT (2007-11-01)

On Tue, Mar 04, 2008, Ralf S. Engelschall wrote:

> > On Mon, Mar 03, 2008 at 10:53:25PM +0100, Ralf S. Engelschall wrote:
> > > The appended patch successfully resolves the bug for me.
> >
> > Looks fine in principle, but *really* needs some tests added...?
> Ok, here it comes. I've first polished the code changes a little bit
> further (variable name, reduced the use of constants::default_encoding,
> etc), added a test suite which checks for all four combinations
> (existing file with or without old trailing newline multiplied with
> new file with our without new trailing newline), and I've adjusted the
> existing test suite where two diff outputs still had added lines before
> deleted lines.
> [...]

Ok, I've today finally resolved this problem by committing my final patch.

                                       Ralf S. Engelschall

reply via email to

[Prev in Thread] Current Thread [Next in Thread]