Re: [Monotone-devel] Re: netsync connection info cleanup

[Thomas Moschny]

Am Wed, 28 Apr 2010 02:50:09 -0400
schrieb address@hidden:

> On Wed, Apr 28, 2010 at 12:36:59PM +0200, Thomas Moschny wrote:
> > Am Sun, 18 Apr 2010 20:49:37 +0200
> > schrieb Thomas Keller <address@hidden>:
> > 
> > > Secondly, I'd actively deprecate any branch name which does not
> > > match the following regular expression, i.e. by throwing a
> > > warning when a branch cert which a different value is created:
> > > 
> > >    ^([\w\d]+([-][\w\d]+)*)(\.[\w\d]+([-][\w\d]+)*)*$
> > 
> > Sounds good to me, but maybe we have to ask our users, whether
> > that'd be ok for them. And we should still allow them to use other
> > branch names if they wish so (because technically, there's no need
> > for such a restriction).
> > 
> > "mtn ls branches | grep -v -E '^(\w+(-\w+)*)(\.\w+(-\w+)*)*$'"
> > shows only one branch that doesn't match in my local copy of the
> > monotone db (prjek.net:tester).
> 
> And what would you do with that branch if this were to become a 
> restriction?

I said I'd agree with the idea of *warning* the user (not *disallowing*
usage of such branch names), I also said I think there's no technical
need to restrict branch names - besides obvious things like \0, and
given there's a way to quote characters if necessary (e.g. using URL
quoting).

- Thomas