Re: [Monotone-devel] key management

[Thomas Keller]

Am 07.08.2010 20:40, schrieb Stephen Leake:
> Stephen Leake <address@hidden> writes:
> 
>> Ok. So 'automate get_public_key' should output the packet format, _not_
>> basic_io. That is very easy to implement.
>>
>> 'automate remove_public_key' is an automate version of 'dropkey', but
>> only removes public keys from the database. That's also easy to implement.
> 
> This is now implemented, in nvm.key_management. Test in
> tests/automate_key_manage, renamed from automate_read_packets.

Ok, I'll review this later.

> I used the command names 'automate pubkey', 'automate dropkey', to match
> the corresponding non-automate commands.
> 
> 'automate dropkey' drops the private key if present, as non-automate
> does. I didn't see any reason to change the behavior.

Ouch - that might not be a good idea. This would e.g. enable the
deletion of the key which is used to authenticate the server, rendering
a running monotone instance completely useless. We cannot even restrict
the execution of this command by argument easily, ie. I don't want to
tell server admins to expand their get_remote_automate_permitted() hook
to specifically exclude the key id for this new command, this is way too
harmful if forgotten.

So please, either split the functionality in two commands
(drop_public_key / drop_private_key) or disable key deletion over
automate. In the former case we could at least give sensible hints for a
server admin to disallow the drop_private_key command completely.

> I wasn't sure where to put 'automate dropkey' and 'automate pubkey' in
> monotone.texi; the 'packets' or 'automate' section. They are in
> 'automate' for now.

All automate commands belong in the automate section.

Thomas.

-- 
GPG-Key 0x160D1092 | address@hidden | http://thomaskeller.biz
Please note that according to the EU law on data retention, information
on every electronic information exchange might be retained for a period
of six months or longer: http://www.vorratsdatenspeicherung.de/?lang=en

signature.asc
Description: OpenPGP digital signature