[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Monotone-devel] [bug #30065] MAXPATHLEN breaks builds on GNU/Hurd

From: Francis Russell
Subject: Re: [Monotone-devel] [bug #30065] MAXPATHLEN breaks builds on GNU/Hurd
Date: Wed, 28 Mar 2012 11:26:51 +0100
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20111114 Icedove/3.1.16

On 28/03/12 09:27, Richard Levitte wrote:

> What did you have in mind?

To be honest, I think the big scary warning put me off more than the
patch itself. Although I do note that the patch appears to use  variable
length stack allocated arrays which aren't valid in C++.

I guess I was thinking of something more like the attached (again
untested), with the idea that the get_current_working_dir()
implementations in both src/{unix,win32}/ could both use it since
they both build strings from the buffer returned by getcwd (and the
majority of added code would no longer be dead). I don't have much idea
on monotone's policy on dynamic memory allocation and error handing for
failures of it though.

Anyway, I was hoping HURD fix would be a mainly non-disruptive change
that wasn't possibly introducing other bugs. Since the code is dead,
replacing MAXPATHLEN with a hard coded value as in
src/{unix,win32}/ is probably better unless there is an intention
to remove some of the hard-coded limits on path lengths.


Attachment: mtn.diff
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]