[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-bug-tracker] [bug #36954] datenum / datevec convert date-time st
From: |
Mike Miller |
Subject: |
[Octave-bug-tracker] [bug #36954] datenum / datevec convert date-time string incorrectly during hour lost to DST |
Date: |
Wed, 23 Aug 2017 03:35:14 -0400 (EDT) |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0 |
Follow-up Comment #20, bug #36954 (project octave):
Yes, the patch also worked for me with minimal testing, and with no noticable
performance impact. It makes me uncomfortable to fix this problem by
converting the time structure back into a string and running regular
expressions and string matching on it, there has got to be a better way... I
just don't know what that is.
Now that I've done a bit of research, I also think this approach is fragile
because it assumes all daylight savings shifts are exactly one hour, which I
have just learned is not always the case.
The test case in this patch is definitely not useful, because it's entirely
dependent on the user's local time zone setting.
I think this still needs some work and testing, and maybe a different
approach. I'll see if I can come up with some cases that can't be solved this
way.
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/bugs/?36954>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
- [Octave-bug-tracker] [bug #36954] datenum / datevec convert date-time string incorrectly during hour lost to DST, Avinoam Kalma, 2017/08/21
- [Octave-bug-tracker] [bug #36954] datenum / datevec convert date-time string incorrectly during hour lost to DST, Philip Nienhuis, 2017/08/21
- [Octave-bug-tracker] [bug #36954] datenum / datevec convert date-time string incorrectly during hour lost to DST, Philip Nienhuis, 2017/08/21
- [Octave-bug-tracker] [bug #36954] datenum / datevec convert date-time string incorrectly during hour lost to DST,
Mike Miller <=
- [Octave-bug-tracker] [bug #36954] datenum / datevec convert date-time string incorrectly during hour lost to DST, Avinoam Kalma, 2017/08/23
- [Octave-bug-tracker] [bug #36954] datenum / datevec convert date-time string incorrectly during hour lost to DST, Mike Miller, 2017/08/23
- [Octave-bug-tracker] [bug #36954] datenum / datevec convert date-time string incorrectly during hour lost to DST, Mike Miller, 2017/08/23
- [Octave-bug-tracker] [bug #36954] datenum / datevec convert date-time string incorrectly during hour lost to DST, Mike Miller, 2017/08/23
- [Octave-bug-tracker] [bug #36954] datenum / datevec convert date-time string incorrectly during hour lost to DST, Mike Miller, 2017/08/23
- [Octave-bug-tracker] [bug #36954] datenum / datevec convert date-time string incorrectly during hour lost to DST, Philip Nienhuis, 2017/08/23
- [Octave-bug-tracker] [bug #36954] datenum / datevec convert date-time string incorrectly during hour lost to DST, Mike Miller, 2017/08/23
- [Octave-bug-tracker] [bug #36954] datenum / datevec convert date-time string incorrectly during hour lost to DST, Mike Miller, 2017/08/23
- [Octave-bug-tracker] [bug #36954] datenum / datevec convert date-time string incorrectly during hour lost to DST, Mike Miller, 2017/08/23
- [Octave-bug-tracker] [bug #36954] datenum / datevec convert date-time string incorrectly during hour lost to DST, Mike Miller, 2017/08/25