[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-patch-tracker] [patch #9084] uitable implementation

From: Noname
Subject: [Octave-patch-tracker] [patch #9084] uitable implementation
Date: Sat, 23 Dec 2017 06:45:13 -0500 (EST)
User-agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:57.0) Gecko/20100101 Firefox/57.0

Follow-up Comment #23, patch #9084 (project octave):

I merged the "file #39340:patch_9084_uitable-20170102.diff" to the current
mercurial snapshot (9a9b2e0596f5). I did compile against QT5. Some deprecated
warnings do occur (is_bool_type -> islogical,is_empty -> isempty etc.) but
nothing harmful.

Because the author has asked for feedback, i can say that the appearance of
this uitable patch is better than the uitable implementation in Matlab. In
Matlab the slider position always resets as the table is modified what is
really bothering and lots of people are complaining about that. To change this
behaviour you have to use "undocumented Matlab". Here the slider remains at
its actual position. Way better. Please don't change this behaviour and keep
everything as it is.

I can say everything works fine (e.g. does not segfault, the two callbacks are
okay etc.). As long as i set the table properties via set()

> f = figure();
> htable=uitable('ColumnEditable',true);   
> set(htable,'data',zeros(9,3));

everything is fine but if i create the table directly

> uitable('ColumnEditable',true,'Data',zeros(9,3));

what's happening is that as a cell is modified the cell disappears and a
message "Table data is not editable at this location" appears at the promt.

I could track this down to table.cc 
void Table::itemChanged (QTableWidgetItem* item)
octave_value data = octave_value(m_curData);

where we find

if (row < data.rows () && col < data.columns ())

The two  values data.rows () and data.columns () remain zero in the second
initialization case but are set correctly to the table dimensions if the table
is setup with set().

I am to unexperienced with octave but this looks to me not necessarily like a
bug in Table.cc but maybe something has changed in the octave interface in the
past year.

Best regards Hg200


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]