[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-patch-tracker] [patch #9084] uitable implementation

From: Noname
Subject: [Octave-patch-tracker] [patch #9084] uitable implementation
Date: Mon, 25 Dec 2017 09:21:18 -0500 (EST)
User-agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:57.0) Gecko/20100101 Firefox/57.0

Follow-up Comment #25, patch #9084 (project octave):

Well - if we write m_curData after Table::Table() somewhere at line 444 by
inserting "m_curData = octave_value(tp.get_data ());":

Table::Table (const graphics_object& go, QTableWidget* tableWidget)
    : Object (go, tableWidget), m_tableWidget(tableWidget), m_curData(),
    uitable::properties& tp = properties<uitable> ();
    m_curData = octave_value(tp.get_data ());
    Matrix bb = tp.get_boundingbox (false);

the problem dissappears.

However i am unsure about the consequences: m_curData is a private. Where is
m_curData() coming from and at which point (file, line) is Table::Table()
instantiated? I personally would expect m_curData should be set as the object
is instantianated.

So for those who want to give it a try i created a patch from my local HG
directory. This patch is identical to  patch_9084_uitable-20170102.diff but
refers to HG ID 9a9b2e0596f5ab013b5180177d4d010934f58c7b. I havent included
the above mentioned line because i cannot say wheather this a "bad-style" fix.
The only contribution i made is the removal of the deprecated warnings by

is_complex_type -> iscomplex
is_bool_type -> islogical
is_numeric_type -> isnumeric
is_integer_type -> isinteger
is_empty -> isempty
is_cell -> iscell

The patch compiles with QT5 and QT4 without any warnings (Fedora 25).

Best regards HG200

(file #42724)

Additional Item Attachment:

File name: patch_9084_uitable-20171223_nowarnings.diff Size:102 KB


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]