RE: [Openexr-devel] OpenEXR build bug-fixes

[Wojciech Jarosz]

I just caught the same acinclude.m4 syntax error yesterday and the fix is now in CVS. There was also a similar bug regarding the use of have_cg in configure.ac which I have now fixed.

IlmThreadSemaphore.cpp is correct. That file implements a dummy semaphore if no threading is supported on the platform. The other IlmThreadSemaphore*.cpp files implement semaphores using various system dependent synchronization primitives. Other classes in IlmThread also have similar dummy implementations. I have added comments to those files now to clarify this for the future.


-wojciech


-----Original Message-----
From: address@hidden on behalf of Bob Friesenhahn
Sent: Mon 8/22/2005 10:20 PM
To: Drew Hess
Cc: address@hidden
Subject: [Openexr-devel] OpenEXR build bug-fixes

The attached patch fixes a number of OpenEXR build bugs that I noticed
while building the CVS version of OpenEXR under Solaris 9.  Much of
this patch was previously described to this list back in April.  None
of these fixes are specific to Solaris.

The edit to acinclude.m4 fixes a shell syntax error.

The edits to the various Makefile.am files properly informs Automake
of the library dependencies the way it is supposed to be done with
Automake.  The method currently used does not work portably.  The
ordering of libraries is not by accident.  Unless the libraries are
listed in this order (increasing dependency), the link fails under
Solaris.

The edit to IlmThread/IlmThreadSemaphore.cpp seems pretty suspicious
to me.  It was necessary since otherwise the method implementations
are missing entirely.  Empty methods don't do very good at locking
though.  Maybe this file is a work in progress.

Bob
======================================
Bob Friesenhahn
address@hidden, http://www.simplesystems.org/users/bfriesen/
GraphicsMagick Maintainer,    http://www.GraphicsMagick.org/