Re: [Pan-users] [PATCH] Minor Icon Menu Cleanup

[Charles Kerr]

On Thu, May 02, 2002 at 01:12:27AM +1200, mdew wrote:
> Modifyed a few Icon defaults..
> Bound "Mark Unread" to Shift-U
> Separator in Go/ (In Between the Nexts' and Previous's)
> 
> gui.c:1895: warning: excess elements in array initializer
> gui.c:1895: warning: (near initialization for `main_menu_entries'
> 
> Just one compile warning... err ;) Pan works fine still...
> Patch for 0.11.91 (GTK2)

Gotta change the #define MAIN_MENU_ENTRIES_QTY on line 157
when you change the number of entries.  This is a dumb workaround
to some ANSI C requirements for static arrays.

> Im still getting around GTK2, so Im learning on the way :)

No problem.  Patches are always welcome. :)

The new icons for cancel and import/export .newsrc are better than 0.11.91's.
Using JUSTIFY_LEFT and JUSTIFY_FILL for get-new works too, oddly enough. :)

IMO a warning icon for `delete group' is less informative than the delete icon.
There's a confirmation dialog, so they still have a chance to back out.

The icons we use in the filter dialog and articlelist are probably better for
Mark Read and Mark Unread, just for consistency's sake.

I don't understand using GTK_STOCK_OK for Articles|Download...?

cheers,
Charles