[pdf-devel] Problems with task #64

[gerel]

Hey,

I just tried to change pdf_char_t to be 'char' and there are some serious
warnings that tell me we shouldn't do it (I marked the most problematic with 3
asterisks), see:

***base/pdf-stm-f-rl.c:180: warning: comparison is always false due to limited
range of data type
***base/pdf-stm-f-rl.c:185: warning: comparison is always true due to limited 
range
of data type
***base/pdf-stm-f-rl.c:202: warning: comparison is always false due to limited
range of data type
base/pdf-stm.c:537: warning: passing argument 2 of 'stm->backend.funcs.read'
from incompatible pointer type
base/pdf-stm.c:548: warning: passing argument 2 of 'pdf_stm_apply_filters' from
incompatible pointer type
base/pdf-stm.c:563: warning: passing argument 2 of 'pdf_stm_apply_filters' from
incompatible pointer type
base/pdf-stm.c:569: warning: pointer targets in passing argument 2 of
'stm->backend.funcs.write' differ in signedness
***base/pdf-stm-f-flate.c:116: warning: pointer targets in passing argument 1 of
'compress' differ in signedness
***base/pdf-stm-f-flate.c:116: warning: pointer targets in passing argument 3 of
'compress' differ in signedness
base/pdf-stm-f-flate.c:152: warning: pointer targets in assignment differ in
signedness
base/pdf-stm-f-flate.c:162: warning: pointer targets in assignment differ in
signedness

You may think of doing some more casts but then... are we solving anything ?
(sort of an endless problem)

What is your opinion guys ?

-gerel