[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [pdf-devel] make syntax-check
From: |
gerel |
Subject: |
Re: [pdf-devel] make syntax-check |
Date: |
Wed, 03 Sep 2008 11:41:42 -0700 (PDT) |
> Date: Tue, 02 Sep 2008 22:18:09 +0200
> From: address@hidden
>
> Rather than a script to do that, I suggest we write a bzr
> hook. It'd be good to just have a hook thats run after a commit
> (since you have to commit before generating a merge directive) and
> does syntax-check as well as running the test suite.
>
> A pre-commit hook (if that thing exist in bazaar) makes more sense for
> this, isnt it?
>
Hey jemarch, you can install it in pre-commit time just by changing:
branch.Branch.hooks.install_named_hook('post_commit', post_commit_hook,
'Patch safety scripts hook')
with:
branch.Branch.hooks.install_named_hook('pre_commit', post_commit_hook,
'Patch safety scripts hook')
But that doesn't mean the commit isn't done (and I doubt you can avoid the
commit with a hook), so I guess it's the same at the end.
cheers
-gerel
- Re: [pdf-devel] make syntax-check, (continued)
- Re: [pdf-devel] make syntax-check, gerel, 2008/09/03
- Re: [pdf-devel] make syntax-check, gerel . foo, 2008/09/03
- Re: [pdf-devel] make syntax-check, jemarch, 2008/09/03
- Re: [pdf-devel] make syntax-check, gerel, 2008/09/03
- Re: [pdf-devel] make syntax-check, jemarch, 2008/09/03
- Re: [pdf-devel] make syntax-check, gerel, 2008/09/03
- Re: [pdf-devel] make syntax-check, gerel, 2008/09/03
- Re: [pdf-devel] make syntax-check, jemarch, 2008/09/03
- Re: [pdf-devel] make syntax-check, gerel, 2008/09/03
- Re: [pdf-devel] make syntax-check, jemarch, 2008/09/03
Re: [pdf-devel] make syntax-check,
gerel <=
Re: [pdf-devel] make syntax-check, jemarch, 2008/09/03
Re: [pdf-devel] make syntax-check, gerel, 2008/09/03