Re: [pdf-devel] make syntax-check

[jemarch]

Hi Zac.

    > > If you write a suitable python script to do that in bazaar please send
    > > it here and I will put it in prmgt/
    > > 
    > 
    > I'll see what I can do.
    > 

   Hey guys, I just wrote and tested a small hook, it works ok for me.

Nice, many thanks.

   Some notes first,

   1. In order to place the script in the "prmgt" directory we also need to set
      "BZR_PLUGIN_PATH=./prmgt" (you can test it doing 'bzr hooks')

Ok. The user may want to do this or, alternatively, install the plugin
in her ~/.bazaar/plugins directory.

   2. The commit command must be run from the projects root
      directory. (otherwise bzr will ignore our hook, it seems to be
      an internal issue regarding bzr)

Maybe you can fix it by using an absolute path for BZR_PLUGIN_PATH?

   branch.Branch.hooks.install_named_hook('post_commit', post_commit_hook,
                                    'Patch safety scripts hook')

This is a post-commit hook... that means that the commit would be done
in any case, isnt it?

Since it is easy to undo a commit using bazaar this hook may be still
useful. Can you please write down proper headers in the script and
write down a note in the hackers guide about how to use it? Then I
will install it in the trunk.

   The output is correct, 'make check' is failing due to,

   base/text/pdf-text-cmp.c:283:F:pdf_text_cmp:pdf_text_cmp_006:0: Failure
   'pdf_text_init() != PDF_OK' occured

Hm. I see that almost all of the text tests are failing
(http://www.gnupdf.org/Lib:Unit_Testing_Report#Test_Suite_text). 

Aleks, can you take a look at this? The error conditions are all of
the form "pdf_text_init() != PDF_OK". Maybe it is related with
locales.