[pdf-devel] Base Types API

[Jeffrey Walton]

Hi All/Jose,

Below is a list of functions of interest relating to pdf_i64_t from
http://gnupdf.org/Lib:API_Consistency_Report. I believe they make up
the public functions exposed by pdf-type.h/pdf-type.c.

The items with an asterisk (*) are not used. In general, they are a
pdf_i32_t variant of the 64 bit function.

Can the functions with an asterisk be removed? If the functions are
not 'code proliferation' added over time, I will write test cases for
them.

If the functions with asterisks are part of the official API, should
all functions have a <fn>_i32 variant for consistency? For example,
pdf_i64_abs_i32 and pdf_i64_neg_i32.

Finally, I did find a need for pdf_i64_eq() and pdf_i64_neq(). I'd
like to add them to the public specification. I also found a need for
pdf_i64_shl() and pdf_i64_shr(). I don't know if they should be public
or private, so I'd like to error towards private.

Comments/Suggestions/Directions are welcomed and desired.

Jeff

pdf_i64_new()
pdf_i64_new_i32()
pdf_i64_assign()
* pdf_i64_assign_quick()
pdf_i64_copy()

pdf_i64_add()
* pdf_i64_add_i32()
pdf_i64_subtract()
* pdf_i64_subtract_i32_min()
* pdf_i64_subtract_i32_sub()
pdf_i64_mult()
* pdf_i64_mult_i32()
pdf_i64_div()
* pdf_i64_div_i32_dividend()
* pdf_i64_div_i32_divisor()
pdf_i64_mod()
* pdf_i64_mod_i32_dividend()
* pdf_i64_mod_i32_divisor()

pdf_i64_abs()
pdf_i64_neg()

pdf_i64_cmp()
* pdf_i64_cmp_i32()

pdf_i64_to_i32()