Re: [pdf-devel] utils/pdf-filter.c: found 2 small problems/bugs?

[Aleksander Morgado]

Hi Georg,

> 
> while testing the prediction filter I found 2 small problems/bugs in
> utils/pdf-filter.c:
> 
> 1.) Calling ./pdf-filter with "--lzwenc --lzw-earlychange" the
> earlychange arg is ignored. Because of the getopt_long loop design args
> will only have an effect if named before the FILTER. Most simple fix
> would be to make call convention  [FILTER_ARGS FILTER]
> instead of [FILTER FILTER_ARGS] (in the patch below)
> But maybe it is more comfortable with some extra variables, so we can
> call in any order. I can send a patch/merge directive for this too.
> 

I would fix it so that we do not depend on the order of the args, or at
least so that we follow the [FILTER FILTER_ARGS] order, which seems more
natural.

> 2.) Calling ./pdf-filter with stdin and (input length % BUF_SIZE == 0)
> will run into a libgnupdf ASSERT, because fread returns 0 if stdin is
> empty and puts this into pdf_stm_write call. (additional if added)
> 
> Patch to fix both problems is attached.
> 

This second fix is ok.

Could you split the patch into different commits, and send bazaar merge
directives (with ChangeLog entry included and such)?

Thanks!

-- 
Aleksander

signature.asc
Description: This is a digitally signed message part