[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [pdf-devel] utils/pdf-filter.c: found 2 small problems/bugs?
From: |
Jose E. Marchesi |
Subject: |
Re: [pdf-devel] utils/pdf-filter.c: found 2 small problems/bugs? |
Date: |
Wed, 06 Jul 2011 19:19:15 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) |
> 1.) Calling ./pdf-filter with "--lzwenc --lzw-earlychange" the
> earlychange arg is ignored. Because of the getopt_long loop design args
> will only have an effect if named before the FILTER. Most simple fix
> would be to make call convention [FILTER_ARGS FILTER]
> instead of [FILTER FILTER_ARGS] (in the patch below)
> But maybe it is more comfortable with some extra variables, so we can
> call in any order. I can send a patch/merge directive for this too.
I would fix it so that we do not depend on the order of the args, or
at least so that we follow the [FILTER FILTER_ARGS] order, which
seems more natural.
I find [FILTER FILTER_ARGS] better than [FILTER_ARGS FILTER]. But,
whatever order is used, the order is important in order to support
several filters of the same type in the same command line.
--
Jose E. Marchesi address@hidden
GNU Project http://www.gnu.org