Re: [phpGroupWare-developers] Fixing bugs

[Benoit Hamet]

Hi Sigurd,

Sigurd Nes a écrit :
> 
> Hi Caeies
> 
> I really think we should test the modules in my personal repository
> before starting to fix the old trunk.
> 
> especially admin, phpgwapi, setup and preferences has bee subjected to
> massive enhancement/improvements compared to the old trunk.
If you have working carefully, this should not be a problem. When I see
fixes in email apps not taking care of coding standards ... I'm more
woried ...

(Please use phpgw::get_var() call instead of $_POST or whatever $_ vars).


> 
> It will save a lot of work if we could consider this as the new base for
> improvements.
If I was considering your code base as the new base for improvements, I
will have ask you to directly commit into trunk ... As already said, we
will merge features from personal branches into trunk. If you have fixes
to commit into trunk before adding new features, please point us the
patches to review for fixes and not features ...


> 
> 
> (The member stuff active/nonactive users are all working fine)
?

> 
> If we disagree on stuff I have done - that's fine we can take it from
> there - but it will get us moving a lot faster.
If we have easier way to fix trunk, I agree with you.

Regards,

Caeies