[patch #5520] Case filter for missing values.

[Ben Pfaff]

Follow-up Comment #1, patch #5520 (project pspp):

 I see here looks good.  But I don't see the code for the
casefilter functions.  Are they in new files that were left out of the
patch?

The GNU coding standards say to format do-while loops as:
     do
       {
         a = foo (a);
       }
     while (a > 0);

I'd prefer to have a casefilter_clone function rather than open-coding
it in casereader_clone and casefile_get_reader.

I'm not actually sure we need to ref-count casefilters: it seems that
there's an explicit casefilter_create and casefilter_destroy at the
top level anyhow.  Do casefilters ever outlive that top-level
casefilter_destroy?



    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?5520>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/