[patch #5653] Make the GUI's data sheet update itself properly, Phase 2

[Ben Pfaff]

Follow-up Comment #1, patch #5653 (project pspp):

Looks good.  A few comments:

Could the order of arguments to dict_copy_callbacks be reversed?  For all
other dict_ functions that modify a dictionary, the dictionary that is
modified is the first argument.

Do we want a dataset factory to go along with the casefile factory?
Maybe in the future.

I didn't quite understand the change to src/ui/gui/syntax-editor.c.  Are we
assured that there is always a data source at this point?  If not, then this
is likely to confuse some commands.

I didn't carefully read the gui changes.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?5653>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/