[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu-devel] [PATCH 09/10] target/arm: Get IL bit correct
From: |
Richard Henderson |
Subject: |
Re: [Qemu-arm] [Qemu-devel] [PATCH 09/10] target/arm: Get IL bit correct for v7 syndrome values |
Date: |
Mon, 15 Oct 2018 08:41:38 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 |
On 10/12/18 7:42 AM, Peter Maydell wrote:
> For the v7 version of the Arm architecture, the IL bit in
> syndrome register values where the field is not valid was
> defined to be UNK/SBZP. In v8 this is RES1, which is what
> QEMU currently implements. Handle the desired v7 behaviour
> by squashing the IL bit for the affected cases:
> * EC == EC_UNCATEGORIZED
> * prefetch aborts
> * data aborts where ISV is 0
>
> (The fourth case listed in the v8 Arm ARM DDI 0487C.a in
> section G7.2.70, "illegal state exception", can't happen
> on a v7 CPU.)
>
> This deals with a corner case noted in a comment.
Reviewed-by: Richard Henderson <address@hidden>
> if (cs->exception_index != EXCP_IRQ && cs->exception_index != EXCP_FIQ) {
> +
> + if (!arm_feature(env, ARM_FEATURE_V8)) {
Extra line.
r~
- Re: [Qemu-arm] [Qemu-devel] [PATCH 03/10] target/arm: Implement HCR.FB, (continued)
- [Qemu-arm] [PATCH 04/10] target/arm: Implement HCR.DC, Peter Maydell, 2018/10/12
- [Qemu-arm] [PATCH 05/10] target/arm: ISR_EL1 bits track virtual interrupts if IMO/FMO set, Peter Maydell, 2018/10/12
- [Qemu-arm] [PATCH 07/10] target/arm: Implement HCR.PTW, Peter Maydell, 2018/10/12
- [Qemu-arm] [PATCH 06/10] target/arm: Implement HCR.VI and VF, Peter Maydell, 2018/10/12
- [Qemu-arm] [PATCH 09/10] target/arm: Get IL bit correct for v7 syndrome values, Peter Maydell, 2018/10/12
- Re: [Qemu-arm] [Qemu-devel] [PATCH 09/10] target/arm: Get IL bit correct for v7 syndrome values,
Richard Henderson <=
- [Qemu-arm] [PATCH 10/10] target/arm: Report correct syndrome for FP/SIMD traps to Hyp mode, Peter Maydell, 2018/10/12
- [Qemu-arm] [PATCH 08/10] target/arm: New utility function to extract EC from syndrome, Peter Maydell, 2018/10/12