[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v3 4/5] blkdebug: Add ability to override unmap
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-block] [PATCH v3 4/5] blkdebug: Add ability to override unmap geometries |
Date: |
Wed, 7 Dec 2016 15:35:21 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 02.12.2016 um 20:22 hat Eric Blake geschrieben:
> Make it easier to simulate various unusual hardware setups (for
> example, recent commits 3482b9b and b8d0a98 affect the Dell
> Equallogic iSCSI with its 15M preferred and maximum unmap and
> write zero sizing, or b2f95fe deals with the Linux loopback
> block device having a max_transfer of 64k), by allowing blkdebug
> to wrap any other device with further restrictions on various
> alignments.
>
> Signed-off-by: Eric Blake <address@hidden>
>
> ---
> v3: improve legibility of bounds checking, improve docs
> v2: new patch
> ---
> qapi/block-core.json | 27 ++++++++++++++-
> block/blkdebug.c | 96
> ++++++++++++++++++++++++++++++++++++++++++++++++++--
> 2 files changed, 120 insertions(+), 3 deletions(-)
>
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index c29bef7..26f3e9f 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -2068,6 +2068,29 @@
> # @align: #optional required alignment for requests in bytes,
> # must be power of 2, or 0 for default
> #
> +# @max-transfer: #optional maximum size for I/O transfers in bytes,
> +# must be multiple of the larger of @align and and 512
s/and and/and/
> +# (but need not be a power of 2), or 0 for default
> +# (since 2.9)
What is the reason for the 512 bytes restriction? Not really a problem,
though, allowing more values later is easier than restricting them.
The rest looks good.
Kevin
- Re: [Qemu-block] [PATCH v3 2/5] blkdebug: Add pass-through write_zero and discard support, (continued)
Re: [Qemu-block] [PATCH v3 2/5] blkdebug: Add pass-through write_zero and discard support, Kevin Wolf, 2016/12/07
[Qemu-block] [PATCH v3 3/5] blkdebug: Simplify override logic, Eric Blake, 2016/12/02
[Qemu-block] [PATCH v3 4/5] blkdebug: Add ability to override unmap geometries, Eric Blake, 2016/12/02
[Qemu-block] [PATCH v3 5/5] tests: Add coverage for recent block geometry fixes, Eric Blake, 2016/12/02