[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v3 4/5] blkdebug: Add ability to override unmap
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [PATCH v3 4/5] blkdebug: Add ability to override unmap geometries |
Date: |
Wed, 7 Dec 2016 09:11:39 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 |
On 12/07/2016 08:35 AM, Kevin Wolf wrote:
>> +++ b/qapi/block-core.json
>> @@ -2068,6 +2068,29 @@
>> # @align: #optional required alignment for requests in bytes,
>> # must be power of 2, or 0 for default
>> #
>> +# @max-transfer: #optional maximum size for I/O transfers in bytes,
>> +# must be multiple of the larger of @align and and 512
>
> s/and and/and/
>
>> +# (but need not be a power of 2), or 0 for default
>> +# (since 2.9)
>
> What is the reason for the 512 bytes restriction?
Probably because I wrote the patch prior to your work to make blkdebug
byte-based, and then forgot to touch it up on rebase.
> Not really a problem,
> though, allowing more values later is easier than restricting them.
I'll see if I can drop the restriction, or at least improve the text,
for v4.
>
> The rest looks good.
>
> Kevin
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-block] [PATCH v3 2/5] blkdebug: Add pass-through write_zero and discard support, (continued)