[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH v2] block: maintain persistent disabled bitmaps

From: Vladimir Sementsov-Ogievskiy
Subject: Re: [Qemu-block] [PATCH v2] block: maintain persistent disabled bitmaps
Date: Fri, 2 Feb 2018 18:18:17 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2

31.01.2018 22:04, Max Reitz wrote:
On 2018-01-29 19:43, Max Reitz wrote:
On 2018-01-22 11:41, Vladimir Sementsov-Ogievskiy wrote:
To maintain load/store disabled bitmap there is new approach:

  - deprecate @autoload flag of block-dirty-bitmap-add, make it ignored
  - store enabled bitmaps as "auto" to qcow2
  - store disabled bitmaps without "auto" flag to qcow2
  - on qcow2 open load "auto" bitmaps as enabled and others
    as disabled (except in_use bitmaps)

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Reviewed-by: John Snow <address@hidden>
Thanks, looks very reasonable.  Applied to my block branch:

...aaand I've only just now seen that iotest 176 will need to be fixed
along with this, so I'm going to unqueue this patch for now.

ohh, sorry for that. Will resend today.

And when I'm already at it: Should we add deprecation information to

didn't find anything in qemu-doc.texi about dirty bitmaps, so I think, no.

Is there a way to generate some documentation files from qapi comments? Where is it?


Best regards,

reply via email to

[Prev in Thread] Current Thread [Next in Thread]