[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH v2 3/6] qapi: add block-dirty-bitma
Re: [Qemu-block] [Qemu-devel] [PATCH v2 3/6] qapi: add block-dirty-bitmap-enable/disable
Fri, 2 Feb 2018 18:37:03 +0300
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2
22.01.2018 22:56, John Snow wrote:
On 01/22/2018 02:51 PM, Eric Blake wrote:
On 01/22/2018 03:09 AM, Vladimir Sementsov-Ogievskiy wrote:
I have to admit exposing this interface still makes me nervous, but :)
Mechanically correct, and with suggesting phrasing changes:
Reviewed-by: John Snow <address@hidden>
Should we go with an x- prefix for now, and let things settle for a
release before promoting it to fully supported, just in case we find
something that justifies your nervousness in accepting the interface?
I proposed as much in a reply to the cover letter; I'm willing to take
patch one now for the sake of migration; the rest of this series I want
a test suite that helps document the anticipated use case, or otherwise
an x- prefix for the command names.
Give me a try with test, and if it will still be unclear, then let's add
x- prefix for first steps.
(of course, my aim is to push the api without x- prefixes =)
- Re: [Qemu-block] [Qemu-devel] [PATCH v2 3/6] qapi: add block-dirty-bitmap-enable/disable,
Vladimir Sementsov-Ogievskiy <=