qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 8fbc12: tracetool: Include thread id informat


From: GitHub
Subject: [Qemu-commits] [qemu/qemu] 8fbc12: tracetool: Include thread id information in log ba...
Date: Thu, 13 Dec 2018 10:44:20 -0800

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 8fbc12f324135cf579277c212ab8690ca9174512
      
https://github.com/qemu/qemu/commit/8fbc12f324135cf579277c212ab8690ca9174512
  Author: Fabiano Rosas <address@hidden>
  Date:   2018-12-12 (Wed, 12 Dec 2018)

  Changed paths:
    M scripts/tracetool/backend/log.py

  Log Message:
  -----------
  tracetool: Include thread id information in log backend

Currently the log backend prints the process id of QEMU at the start
of each output line, but since threads share the same PID there is no
clear distinction between their outputs.

Having the thread id present in the log makes it easier to see when
output comes from different threads. E.g.:

address@hidden:qemu_mutex_lock waiting on mutex 0x1103ee60 
(/root/qemu/util/main-loop.c:236)
...
address@hidden:qemu_mutex_unlock released mutex 0x1103ee60 
(/root/qemu/cpus.c:1238)
address@hidden:qemu_mutex_locked taken mutex 0x1103ee60 (/root/qemu/cpus.c:1257)
^here

In the above, 12423 is the main process id and 12430 & 12431 are the
two vcpu threads.

 (qemu) info cpus
 * CPU #0: thread_id=12430
   CPU #1: thread_id=12431

Suggested-by: Murilo Opsfelder Araujo <address@hidden>
Signed-off-by: Fabiano Rosas <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: 7ff5920717d413d8b7c3ba13d9a0805291b9e6ec
      
https://github.com/qemu/qemu/commit/7ff5920717d413d8b7c3ba13d9a0805291b9e6ec
  Author: Larry Dewey <address@hidden>
  Date:   2018-12-12 (Wed, 12 Dec 2018)

  Changed paths:
    M trace/simple.c

  Log Message:
  -----------
  trace: simple style changes

This changes two lines in simple.c that end with a comma, and replaces them
with a semi-colon.

Signed-off-by: Larry Dewey <address@hidden>
Reviewed-by: John Snow <address@hidden>
Message-id: address@hidden
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: 2d894e48362ad2a576fca929dcca1787f43a8af6
      
https://github.com/qemu/qemu/commit/2d894e48362ad2a576fca929dcca1787f43a8af6
  Author: Peter Maydell <address@hidden>
  Date:   2018-12-13 (Thu, 13 Dec 2018)

  Changed paths:
    M scripts/tracetool/backend/log.py
    M trace/simple.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/stefanha/tags/tracing-pull-request' 
into staging

Pull request

Minor tracing improvements.

# gpg: Signature made Wed 12 Dec 2018 10:15:30 GMT
# gpg:                using RSA key 9CA4ABB381AB73C8
# gpg: Good signature from "Stefan Hajnoczi <address@hidden>"
# gpg:                 aka "Stefan Hajnoczi <address@hidden>"
# Primary key fingerprint: 8695 A8BF D3F9 7CDA AC35  775A 9CA4 ABB3 81AB 73C8

* remotes/stefanha/tags/tracing-pull-request:
  trace: simple style changes
  tracetool: Include thread id information in log backend

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/c3ec0fa1a8e8...2d894e48362a
      **NOTE:** This service has been marked for deprecation: 
https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]