Re: [Qemu-devel] [PATCH] PIIX4 SMBus host, EEPROM device emulation

[Fabrice Bellard]

Ed Swierk wrote:
> The attached patch adds SMBus host support to the emulated PIIX4 power
> management device (acpi.c), and adds an emulated serial EEPROM device
> accessible via the SMBus interface.
>
> I tried to follow the Intel 82371AB spec for the SMBus support; the
> interface should be generic enough to implement a variety of
> SMBus-compliant devices.
>
> The EEPROM device can use a file for persistent storage
> (smbus_eeprom.bin in the BIOS directory). If this file does not exist,
> a temporary buffer is used instead.
>
> I tested the devices with Linux using the i2c-piix4 host driver and
> the eeprom chip driver. I have no idea what will happen on other OSes.
>
> Comments and suggestions welcome.
> [...]

OK, but avoid using mmap() in the device code. Moreover, files in the 
BIOS directory are not writable.

Regards,

Fabrice.