[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] PIIX4 SMBus host, EEPROM device emulation

From: Ed Swierk
Subject: Re: [Qemu-devel] [PATCH] PIIX4 SMBus host, EEPROM device emulation
Date: Tue, 23 Jan 2007 14:30:31 -0800

On 1/23/07, Fabrice Bellard <address@hidden> wrote:
OK, but avoid using mmap() in the device code. Moreover, files in the
BIOS directory are not writable.

OK. Would it be better to do the following:

- add a command-line option -seeprom that sets the file to use as
backing store for the smbus_eeprom device

- in main(), open and mmap the file if the -seeprom option is
specified, otherwise allocate a temporary buffer

- add a seeprom buffer argument to each machine's init(), ignored except for pc


reply via email to

[Prev in Thread] Current Thread [Next in Thread]