[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Improve DMA transfers by increasing the buffer
Re: [Qemu-devel] [PATCH] Improve DMA transfers by increasing the buffer size.
Sun, 30 Mar 2008 13:42:01 +0300
Thunderbird 220.127.116.11 (X11/20080226)
Ian Jackson wrote:
Aurelien Jarno writes ("Re: [Qemu-devel] [PATCH] Improve DMA transfers by increasing
the buffer size."):
On Wed, Mar 26, 2008 at 04:35:00PM +0000, Ian Jackson wrote:
Content-Description: message body text
+#define IDE_DMA_BUF_SIZE 131072
Wouldn't it be better to define this value in number of sectors? This
would avoid a few divisions in the code, and anyway the code handling
DMA transfers is working with a number of sectors, not a number of
I don't have much of an opinion about what units it should be in. The
divisions are just at compile-time of course.
I prefer bytes myself, this way it is easy to have all constants using
the same scale factor (1) and avoid worrying about conversions, except
at the last moment when using them.
error compiling committee.c: too many arguments to function