Re: [Qemu-devel] [PATCH 4/5] Use libuuid if available.

[Anthony Liguori]

Gleb Natapov wrote:
> Anthony, thanks for the review.
>
> On Thu, Jun 05, 2008 at 10:18:15AM -0500, Anthony Liguori wrote:
>   
> > > @@ -256,8 +260,14 @@ static void do_info_name(void)
> > >   static void do_info_uuid(void)
> > >  {
> > > +#ifdef CONFIG_UUID
> > > +    char uuid_str[37];
> > > +    uuid_unparse(qemu_uuid, uuid_str);
> > > +    term_printf("%s\n", uuid_str);
> > > +#else
> > >   
> > >       
> > Just use a printf() string here again to eliminate the need for CONFIG_UUID.
> >
> >     
> So may be do not use libuuid at all and just write simple uuid string
> parsing function?
>   

For parsing, sure. But uuid generation requires implementing an 
algorithm from an RFC. I think that warrants using libuuid.

So I'd say only use libuuid for generating random uuids.

Regards,

Anthony Liguori

> --
>                         Gleb.
>
>
>