Re: [Qemu-devel] [PATCH 4/5] Use libuuid if available.

[Anthony Liguori]

Paul Brook wrote:
> On Thursday 05 June 2008, Anthony Liguori wrote:
>   
> > Gleb Natapov wrote:
> >     
> > > Anthony, thanks for the review.
> > >
> > > On Thu, Jun 05, 2008 at 10:18:15AM -0500, Anthony Liguori wrote:
> > >       
> > > > > @@ -256,8 +260,14 @@ static void do_info_name(void)
> > > > >   static void do_info_uuid(void)
> > > > >  {
> > > > > +#ifdef CONFIG_UUID
> > > > > +    char uuid_str[37];
> > > > > +    uuid_unparse(qemu_uuid, uuid_str);
> > > > > +    term_printf("%s\n", uuid_str);
> > > > > +#else
> > > > >           
> > > > Just use a printf() string here again to eliminate the need for
> > > > CONFIG_UUID.
> > > >         
> > > So may be do not use libuuid at all and just write simple uuid string
> > > parsing function?
> > >       
> > For parsing, sure. But uuid generation requires implementing an
> > algorithm from an RFC. I think that warrants using libuuid.
> >     
>
> Can we punt this to management tools? Having qemu create randomly different 
> machines seems like it's going to cause as many problems as it solves.  We've 
> already got things like MAC addresses which are fixed but need to be unique.
>   

Yeah, I was thinking this myself too.  It's not really worth it for just 
uuid generation.

Regards,

Anthony Liguori

> Paul
>