[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/4] qemu:virtio-net: Add support for qemu_vlan_
From: |
Alex Williamson |
Subject: |
Re: [Qemu-devel] [PATCH 3/4] qemu:virtio-net: Add support for qemu_vlan_rxfilter |
Date: |
Thu, 12 Feb 2009 09:36:47 -0700 |
On Thu, 2009-02-12 at 16:26 +0000, Paul Brook wrote:
> > +static void virtio_net_vlan_client_added(void *opaque)
> >...
> > +static void virtio_net_vlan_client_removed(void *opaque)
>
> Why are these two different?
>
> It looks like what you really want is a callback for "Something changed,
> and you need to reset your MAC filter."
I think we'd end up with a race if we only had one callback. For
instance if "change" was the result of a vlan client being removed, the
tap would clear the filter and the nic would try to install a filter.
The results would be different based on the calling order.
Alex
- [Qemu-devel] [PATCH 0/4] qemu: TAP filtering support, Alex Williamson, 2009/02/10
- [Qemu-devel] [PATCH 1/4] qemu:net: Add infrastructure for setting an RX filter through the vlan, Alex Williamson, 2009/02/10
- [Qemu-devel] [PATCH 2/4] qemu:net: Add TAP support for RX filtering on Linux, Alex Williamson, 2009/02/10
- [Qemu-devel] [PATCH 3/4] qemu:virtio-net: Add support for qemu_vlan_rxfilter, Alex Williamson, 2009/02/10
- Re: [Qemu-devel] [PATCH 3/4] qemu:virtio-net: Add support for qemu_vlan_rxfilter, Paul Brook, 2009/02/12
- Re: [Qemu-devel] [PATCH 3/4] qemu:virtio-net: Add support for qemu_vlan_rxfilter,
Alex Williamson <=
- Re: [Qemu-devel] [PATCH 3/4] qemu:virtio-net: Add support for qemu_vlan_rxfilter, Paul Brook, 2009/02/12
- Re: [Qemu-devel] [PATCH 3/4] qemu:virtio-net: Add support for qemu_vlan_rxfilter, Alex Williamson, 2009/02/12
- Re: [Qemu-devel] [PATCH 3/4] qemu:virtio-net: Add support for qemu_vlan_rxfilter, Jamie Lokier, 2009/02/12
- Re: [Qemu-devel] [PATCH 3/4] qemu:virtio-net: Add support for qemu_vlan_rxfilter, Paul Brook, 2009/02/13
- Re: [Qemu-devel] [PATCH 3/4] qemu:virtio-net: Add support for qemu_vlan_rxfilter, Jamie Lokier, 2009/02/13
- Re: [Qemu-devel] [PATCH 3/4] qemu:virtio-net: Add support for qemu_vlan_rxfilter, Paul Brook, 2009/02/13
- Re: [Qemu-devel] [PATCH 3/4] qemu:virtio-net: Add support for qemu_vlan_rxfilter, Jamie Lokier, 2009/02/13
- Re: [Qemu-devel] [PATCH 3/4] qemu:virtio-net: Add support for qemu_vlan_rxfilter, Paul Brook, 2009/02/13
- Re: [Qemu-devel] [PATCH 3/4] qemu:virtio-net: Add support for qemu_vlan_rxfilter, Jamie Lokier, 2009/02/13
- Re: [Qemu-devel] [PATCH 3/4] qemu:virtio-net: Add support for qemu_vlan_rxfilter, Paul Brook, 2009/02/15