[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [patch 2/2] qemu: switch pci device init functions to a
Re: [Qemu-devel] [patch 2/2] qemu: switch pci device init functions to accept devfn
Mon, 13 Apr 2009 13:27:34 +0100
On Monday 13 April 2009, Marcelo Tosatti wrote:
> Some pci device initialization functions do not accept a devfn parameter,
> but instead use "-1", which caused pci_register_device to find the first
> free slot on the given bus.
> Have them accept a "devfn" parameter, and use the newly introduced
> pci_bus_assign_dev_addr function on platform init code to perform
> the "first free" enumeration.
I don't see how this is better. If anything we want the platform code to get
smaller, not larger.