[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [patch 2/2] qemu: switch pci device init functions to a
Re: [Qemu-devel] [patch 2/2] qemu: switch pci device init functions to accept devfn
Tue, 14 Apr 2009 05:17:40 -0300
On Mon, Apr 13, 2009 at 01:27:34PM +0100, Paul Brook wrote:
> On Monday 13 April 2009, Marcelo Tosatti wrote:
> > Some pci device initialization functions do not accept a devfn parameter,
> > but instead use "-1", which caused pci_register_device to find the first
> > free slot on the given bus.
> > Have them accept a "devfn" parameter, and use the newly introduced
> > pci_bus_assign_dev_addr function on platform init code to perform
> > the "first free" enumeration.
> I don't see how this is better. If anything we want the platform code to get
> smaller, not larger.
OK, so, what would you like to see? The proposal where pci dev address
goes directly from devtree to pci_register_device, behind an opaque
type in the way? Or goes through QEMUDevice?
Please be more specific, so we can get somewhere.