[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH 1/4] Add GPL bios as a submodule

From: Avi Kivity
Subject: [Qemu-devel] Re: [PATCH 1/4] Add GPL bios as a submodule
Date: Sun, 17 May 2009 19:23:07 +0300
User-agent: Thunderbird (X11/20090320)

Anthony Liguori wrote:
I really prefer a relative path here, so that people can set up mirrors on an internal server. Also, not everyone can access the git port. It can be worked around, but it's much better to have things working out of the proverbial box.

Do you also include a way to automatically setup the relative path? Otherwise, it's a multi-step process for someone to fetch all of the git trees for building.

I don't understand the question. The relative path is set up once (in .gitmodules), and that's it.

Look at kvm-kmod.git for an example.

We have a lot of ROMs, so this is potentially very undesirable. People can always make local changes to the .gitmodules file.

Not if they're a mirror.

Also, s/roms/firmware/ to be modern.

ROM is a little more specific in my mind. We had a long debate in IRC as to what was appropriate to include in pc-bios. One key requirement is that whatever is there has to be a ROM because of the fact that we install it in a read-only location in the file system.

On embedded boards, the entire operating system stack constitutes "firmware".

I'm not sure I agree, but we have more pressing subjects to bikeshed.

Having said all that, I'd rather see seabios here. Sure, it will take us time to add missing features, if any, but life will be much more pleasant afterwards. We should reduce our ties to the bochs bios, not tighten them.

Actually, I want to include seabios in here too and install it by default.

There's already a -bios option that can be used to change the bios file name. After some basic testing, we can decide whether we should change the default bios we use. With both installed, it's easier to have people check for bugs in one verse the other.

Let's only include seabios then and reject all patches to the bochs bios. If that doesn't motivate people to switch, nothing will.

error compiling committee.c: too many arguments to function

reply via email to

[Prev in Thread] Current Thread [Next in Thread]