[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 1/7] vmware_vga: clean up
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] Re: [PATCH 1/7] vmware_vga: clean up |
Date: |
Wed, 10 Jun 2009 18:08:19 +0300 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
On Tue, Jun 02, 2009 at 03:42:44PM +0900, Isaku Yamahata wrote:
> use NULL instead of 0 for pci_register_device() argument
> for consistency. Any other caller uses NULL.
>
> Signed-off-by: Isaku Yamahata <address@hidden>
ACK.
Isn't this independend of other patches in the series?
If yes, it's probably better to post them separately.
Acked-by: Michael S. Tsirkin <address@hidden>
> ---
> hw/vmware_vga.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/vmware_vga.c b/hw/vmware_vga.c
> index 79da1ff..ee4f10a 100644
> --- a/hw/vmware_vga.c
> +++ b/hw/vmware_vga.c
> @@ -1217,7 +1217,7 @@ void pci_vmsvga_init(PCIBus *bus)
> /* Setup PCI configuration */
> s = (struct pci_vmsvga_state_s *)
> pci_register_device(bus, "QEMUware SVGA",
> - sizeof(struct pci_vmsvga_state_s), -1, 0, 0);
> + sizeof(struct pci_vmsvga_state_s), -1, NULL, NULL);
> pci_config_set_vendor_id(s->card.config, PCI_VENDOR_ID_VMWARE);
> pci_config_set_device_id(s->card.config, SVGA_PCI_DEVICE_ID);
> s->card.config[PCI_COMMAND] = 0x07; /* I/O + Memory
> */
> --
> 1.6.0.2
--
MST
- [Qemu-devel] [PATCH 0/7] pci bridge clean up and multiple pci bus support v2, Isaku Yamahata, 2009/06/02
- [Qemu-devel] [PATCH 1/7] vmware_vga: clean up, Isaku Yamahata, 2009/06/02
- [Qemu-devel] Re: [PATCH 1/7] vmware_vga: clean up,
Michael S. Tsirkin <=
- [Qemu-devel] [PATCH 2/7] qemu: make default_write_config use mask table, Isaku Yamahata, 2009/06/02
- [Qemu-devel] [PATCH 3/7] pci: pci_default_config_write() clean up., Isaku Yamahata, 2009/06/02
- Re: [Qemu-devel] Re: [PATCH 3/7] pci: pci_default_config_write() clean up., Michael S. Tsirkin, 2009/06/10
- Re: [Qemu-devel] Re: [PATCH 3/7] pci: pci_default_config_write() clean up., Isaku Yamahata, 2009/06/15
- Re: [Qemu-devel] Re: [PATCH 3/7] pci: pci_default_config_write() clean up., Michael S. Tsirkin, 2009/06/15