Re: [Qemu-devel] [PATCH 0/7] virtio-net: Filter cleanup/improvements

[Alex Williamson]

On Fri, 2009-06-12 at 18:07 +0100, Mark McLoughlin wrote:
> On Wed, 2009-06-10 at 16:21 +0930, Rusty Russell wrote:
> > On Wed, 10 Jun 2009 04:55:10 am Mark McLoughlin wrote:
> > > Hi Alex,
> > >
> > > On Fri, 2009-06-05 at 14:46 -0600, Alex Williamson wrote:
> > > > This series cleans up a few things around packet filtering.  I've
> > > > probably gone a little overboard on breaking up patches, if we want to
> > > > avoid bumping the save version_id so much, these could be mostly lumped
> > > > together.  The main features here are more efficient handling of the
> > > > filtering between unicast and multicast, better overflow tracking, 
> > > > adding
> > > > more RX modes, and increasing the size of the filter table and control
> > > > queue depth.
> > >
> > > The whole series looks good to me. Please make sure to send Rusty a
> > > patch with the VIRTIO_NET_F_CTRL_RX_EXTRA etc. header additions.
> > 
> > Remain unconvinced that it's worth a feature bit.  It'd pretty obscure 
> > (hell, 
> > even multicast is pretty obscure IRL).
> 
> Yeah, we probably don't need the feature bit - the guest can just handle
> a VIRTIO_NET_ERR status if the host doesn't implement it.
> 
> Alex - if you agree, could you post a qemu patch to kill the
> CTRL_RX_EXTRA feature? And also post a linux/virtio_net.h patch to add
> the new rx modes?

Two votes against it, I'll drop the feature bit.  I'll post the qemu
patch in a minute and follow-up with the linux patch once that goes in.
Thanks,

Alex