[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Re: [PATCH] Add -no-virtio-balloon command-line option
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] Re: [PATCH] Add -no-virtio-balloon command-line option |
Date: |
Mon, 15 Jun 2009 13:04:09 +0200 |
User-agent: |
Gnus/5.11 (Gnus v5.11) Emacs/22.3 (gnu/linux) |
Dor Laor <address@hidden> writes:
> Gerd Hoffmann wrote:
>>>
>>> This new option may be used to disable the virtio-balloon device.
>>>
>>
>> ACK, looks good.
>>
>> And I can drop my lazy patch which just comments out virtio-balloon
>> in the code ;)
>
> Actually, I rather have the balloon disabled by default. It's like any
> other pci device which needs
> explicit command line specification. Why consume a pci slot if not
> implicitly required?
I agree. The command line is plenty magic without implicitly added
PCI devices.
Besides, negative options -no-virtio-balloon lead to ugly
double-negatives like if (!no_virtio_balloon).
- [Qemu-devel] [PATCH] Add -no-virtio-balloon command-line option, Eduardo Habkost, 2009/06/10
- [Qemu-devel] Re: [PATCH] Add -no-virtio-balloon command-line option, Anthony Liguori, 2009/06/10
- [Qemu-devel] Re: [PATCH] Add -no-virtio-balloon command-line option, Eduardo Habkost, 2009/06/10
- Re: [Qemu-devel] Re: [PATCH] Add -no-virtio-balloon command-line option, Gerd Hoffmann, 2009/06/11
- Re: [Qemu-devel] Re: [PATCH] Add -no-virtio-balloon command-line option, Dor Laor, 2009/06/15
- Re: [Qemu-devel] Re: [PATCH] Add -no-virtio-balloon command-line option,
Markus Armbruster <=
- Re: [Qemu-devel] Re: [PATCH] Add -no-virtio-balloon command-line option, Anthony Liguori, 2009/06/15
- Re: [Qemu-devel] Re: [PATCH] Add -no-virtio-balloon command-line option, Dor Laor, 2009/06/15
- Re: [Qemu-devel] Re: [PATCH] Add -no-virtio-balloon command-line option, Anthony Liguori, 2009/06/15
- Re: [Qemu-devel] Re: [PATCH] Add -no-virtio-balloon command-line option, Markus Armbruster, 2009/06/15
- Re: [Qemu-devel] Re: [PATCH] Add -no-virtio-balloon command-line option, Anthony Liguori, 2009/06/15
- [Qemu-devel] [PATCH] Replace -no-virtio-balloon by -balloon, Markus Armbruster, 2009/06/26